-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update manage imports table #1558
Conversation
d69b466
to
d69e399
Compare
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
+ Coverage 39.41% 40.49% +1.07%
==========================================
Files 146 145 -1
Lines 4775 4638 -137
Branches 1138 1087 -51
==========================================
- Hits 1882 1878 -4
+ Misses 2879 2746 -133
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with one suggestion on the error popover with the external href
<a | ||
href="https://tackle-docs.konveyor.io/documentation/doc-installing-and-using-tackle/master/index.html#importing-applications_tackle" | ||
target="_blank" | ||
rel="noreferrer" | ||
> | ||
{t("actions.checkDocumentation")} | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use component client/src/app/components/ExternalLink.tsx
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSV content-wise looks good to me.
Resolves https://issues.redhat.com/browse/MTA-1693
Resolves https://issues.redhat.com/browse/MTA-1716