-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add question mark icon for archetype assessed indicator #1561
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 146 146
Lines 4775 4775
Branches 1138 1138
=======================================
Hits 1882 1882
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: ibolton336 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok.
The layout still overlaps when the browser window width is less than 1750px:
This change is ok, but I do think there are more effective ways to handling displaying the "Not Started" vs "Completed via inheritance from an archetype" vs "Completed assemment/review direct against the application". Maybe text values of "Not Started", "Inherited", "Completed" or "Not Started", "From Archetype", "Completed"? That can be a followup issue.
Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1712?filter=12422675