Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix responsiveness for issues drawer #1562

Merged
merged 2 commits into from
Nov 22, 2023
Merged

🐛 Fix responsiveness for issues drawer #1562

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f62458
:bug: Fix responsiveness for issues drawer
ibolton336 Nov 21, 2023
87dc5ad
Merge branch 'main' into mta-1389
ibolton336 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions client/src/app/pages/issues/issue-detail-drawer/issue-detail-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
Tabs,
TabTitleText,
Tab,
Truncate,
} from "@patternfly/react-core";
import spacing from "@patternfly/react-styles/css/utilities/Spacing/spacing";
import { IssueAffectedFilesTable } from "./issue-affected-files-table";
Expand Down Expand Up @@ -50,21 +49,23 @@ export const IssueDetailDrawer: React.FC<IIssueDetailDrawerProps> = ({
focusKey={issueId || ""}
pageKey="affected-applications"
drawerPanelContentProps={{ defaultSize: "600px" }}
header={
<TextContent>
<Text component="small" className={spacing.mb_0}>
Issue
</Text>
<Title headingLevel="h2" size="lg" className={spacing.mtXs}>
{issue ? getIssueTitle(issue) : ""}
</Title>
</TextContent>
}
>
{isFetching ? (
<AppPlaceholder />
) : !issue ? (
<StateNoData />
) : (
<>
<TextContent>
<Text component="small" className={spacing.mb_0}>
{applicationName}
</Text>
<Title headingLevel="h2" size="lg" className={spacing.mtXs}>
<Truncate content={getIssueTitle(issue)} />
</Title>
</TextContent>
<div>
<Tabs
activeKey={activeTabKey}
onSelect={(_event, tabKey) => setActiveTabKey(tabKey as TabKey)}
Expand All @@ -77,7 +78,7 @@ export const IssueDetailDrawer: React.FC<IIssueDetailDrawerProps> = ({
<IssueAffectedFilesTable issue={issue} />
</Tab>
</Tabs>
</>
</div>
)}
</PageDrawerContent>
);
Expand Down
Loading