Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update migration wave form & modal styles #1563

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 changed the title 🐛 Update migration wave styles 🐛 Update migration wave form & modal styles Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bac9ebe) 39.41% compared to head (3768285) 39.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1563   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files         146      146           
  Lines        4775     4775           
  Branches     1138     1138           
=======================================
  Hits         1882     1882           
  Misses       2879     2879           
  Partials       14       14           
Flag Coverage Δ
client 39.41% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.

Changing the appendTo for the date input really does help.

@ibolton336
Copy link
Member Author

This is a bug that @gitdallas would probably know how to best solve. Not sure the correct PF approach to make the modal /form field css be static when the dropdowns open. Seems like there is a bottom padding on the modal that changes when there is a new "last element" present within the modal scope in the dom.

@ibolton336
Copy link
Member Author

You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.

Changing the appendTo for the date input really does help.

IMO the "to" seemed very out of place. But that is probably a @JustinXHale question.

Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibolton336 ibolton336 merged commit 375db82 into konveyor:main Nov 22, 2023
6 checks passed
@JustinXHale
Copy link
Member

JustinXHale commented Nov 25, 2023

You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.
Changing the appendTo for the date input really does help.

IMO the "to" seemed very out of place. But that is probably a @JustinXHale question.

I agree it does seem out of place, but for PF we do use "to" centered for date and time range. View here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants