-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update migration wave form & modal styles #1563
Conversation
Signed-off-by: ibolton336 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 146 146
Lines 4775 4775
Branches 1138 1138
=======================================
Hits 1882 1882
Misses 2879 2879
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.
Changing the appendTo
for the date input really does help.
client/src/app/pages/migration-waves/components/migration-wave-form.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/migration-waves/components/migration-wave-form.tsx
Outdated
Show resolved
Hide resolved
This is a bug that @gitdallas would probably know how to best solve. Not sure the correct PF approach to make the modal /form field css be static when the dropdowns open. Seems like there is a bottom padding on the modal that changes when there is a new "last element" present within the modal scope in the dom. |
IMO the "to" seemed very out of place. But that is probably a @JustinXHale question. |
Signed-off-by: ibolton336 <[email protected]>
Signed-off-by: ibolton336 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I agree it does seem out of place, but for PF we do use "to" centered for date and time range. View here |
Resolves https://issues.redhat.com/browse/MTA-742