🌱 Refactor patternfly, i18n, and dayjs initialization #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring:
- Explicitly add `i18n` initialization on the root `index.tsx`.
- Move `dayjs` initialization to its own file `dayjs.ts` referenced
from `index.tsx`. This follows the `i18n` init style.
- Move PF css includes from App.tsx to index.tsx
Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
changed the title
|
Nice - LGTM |
ibolton336
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring:
Explicitly add
i18ninitialization on the rootindex.tsx.Move
dayjsinitialization to its own filedayjs.tsreferenced fromindex.tsx. This follows thei18ninit style.Move PF css includes from
App.tsxtoindex.tsx