🐛 Exclude non-required questionnaires in assessed calculation (#1666) #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Resolves https://issues.redhat.com/browse/MTA-1967 Addresses an issue where the assessed boolean for archetypes is set to true when all questionnaires are marked as not-required. Uses the new assessment.required boolean surfaced in konveyor/tackle2-hub@2552233 to filter out these false positives. --------- Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
cherry-pick-pr1666-release-0.3
branch
from
c96c306 to
3aae7b2
Compare
Resolves: https://issues.redhat.com/browse/MTA-2007 Resolves: https://issues.redhat.com/browse/MTA-2056 Backport of #1662 - Removes the auto applied search string when direct navigating using the side nav. This was applying filters that were not registered within the application table ( & other tables). I.E when navigating from the dependencies page, the search string was including an "applications.name" filter which is just referenced as "name" within the applications table. Future iterations may allow us to rewrite the search string when navigating between pages or standardizing on a specific key for app names on the back end. - Adds the ability to parse the url string for initial search values in the dependencies toolbar. - Adds associated clear filters handler to clear the url when the toolbar clear button is pressed. This is necessary to overwrite the initial filter values. Implemented this in dependencies page & applications table. There may be a need to incorporate this into filter toolbar at some point. Signed-off-by: ibolton336 <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: ibolton336 <[email protected]> Co-authored-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: ibolton336 <[email protected]>
ibolton336
force-pushed
the
cherry-pick-pr1666-release-0.3
branch
from
3aae7b2 to
4c0c80e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/MTA-1967
Backport of #1666
Addresses an issue where the assessed boolean for archetypes is set to
true when all questionnaires are marked as not-required. Uses the new
assessment.required boolean surfaced in
konveyor/tackle2-hub@2552233
to filter out these false positives.
Signed-off-by: ibolton336 [email protected]