Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle case when application.archetypes is passed but null #1707

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Feb 27, 2024

Resolves https://issues.redhat.com/browse/MTA-2320

  • Missed a case when calculating associated assessed archetypes to an application. If application is passed to the useFetchArchetypes query but application.archetypes is null, still returning all archetypes instead of an empty list.

@ibolton336 ibolton336 changed the title 🐛 Handle case when application.archetypes is passed but null for … 🐛 Handle case when application.archetypes is passed but null Feb 27, 2024
@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 27, 2024
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibolton336 ibolton336 merged commit 59ad200 into konveyor:main Feb 28, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
Resolves https://issues.redhat.com/browse/MTA-2320

- Missed a case when calculating associated assessed archetypes to an
application. If application is passed to the useFetchArchetypes query
but application.archetypes is null, still returning all archetypes
instead of an empty list.

---------

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
ibolton336 added a commit that referenced this pull request Feb 28, 2024
…1710)

Resolves https://issues.redhat.com/browse/MTA-2320

- Missed a case when calculating associated assessed archetypes to an
application. If application is passed to the useFetchArchetypes query
but application.archetypes is null, still returning all archetypes
instead of an empty list.

---------

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Ian Bolton <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants