Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update developer documentation #1726

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

rszwajko
Copy link
Collaborator

Changes:

  1. fix dead links i.e. to PF4 components or refactored code
  2. in README
    1. OLM addon issue
    2. be more general about minikube drivers i.e. rootless or without VMs
    3. prefer port forwarding to proxy when accessing dashboard (seems safer)
  3. in INTERNATIONALIZATION - comment that questionnaire is data imported from YAML files

Changes:
1. fix dead links i.e. to PF4 components or refactored code
2. in README
   a) OLM addon issue
   b) be more general about minikube drivers i.e. rootless
      or without VMs
   c) prefer port forwarding to proxy when accessing
      dashboard (seems safer)
3. in INTERNATIONALIZATION - comment that questionnaire is data
   imported from YAML files

Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko rszwajko marked this pull request as ready for review March 6, 2024 14:50
@rszwajko rszwajko requested review from sjd78, ibolton336 and mturley March 6, 2024 15:06
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for going through this, Radek. Just a few tweaks requested. Nice work!

INTERNATIONALIZATION.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
development.md Show resolved Hide resolved
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 👍 for link fixes
  • 👍 for the minikube dashboard access via port-forward
  • 👍 for the install and OLM install changes
  • Ian's suggestions look good as well

README.md Outdated Show resolved Hide resolved
rszwajko and others added 2 commits March 8, 2024 21:11
Co-authored-by: Ian Bolton <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Co-authored-by: Ian Bolton <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@ibolton336 ibolton336 merged commit 6b805b5 into konveyor:main Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants