Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 [backport release-0.2] Update Dockerfile and image build #1880

Merged
merged 2 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions .github/workflows/march-image-build-push.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: 'Build and Push Multi-Arch Image'
name: "Build and Push Multi-Arch Image"

on:
workflow_dispatch:
push:
branches:
- 'main'
- 'release-*'
- "main"
- "release-*"
tags:
- 'v*'
- "v*"

concurrency:
group: march-build-${{ github.ref }}
Expand All @@ -17,17 +17,16 @@ jobs:
push-quay:
name: Build and Push Manifest
runs-on: ubuntu-22.04
strategy:
fail-fast: false
steps:
- name: Checkout Push to Registry action
uses: konveyor/release-tools/build-push-quay@main
with:
architectures: "amd64, arm64, ppc64le, s390x"
containerfile: "./Dockerfile"
image_name: "tackle2-ui"
image_namespace: "konveyor"
image_registry: "quay.io"
quay_publish_robot: ${{ secrets.QUAY_PUBLISH_ROBOT }}
quay_publish_token: ${{ secrets.QUAY_PUBLISH_TOKEN }}
ref: ${{ github.ref }}
- name: Checkout Push to Registry action
uses: konveyor/release-tools/build-push-quay@main
with:
architectures: "amd64, arm64, ppc64le, s390x"
containerfile: "./Dockerfile"
extra-args: "--ulimit nofile=4096:4096"
image_name: "tackle2-ui"
image_namespace: "konveyor"
image_registry: "quay.io"
quay_publish_robot: ${{ secrets.QUAY_PUBLISH_ROBOT }}
quay_publish_token: ${{ secrets.QUAY_PUBLISH_TOKEN }}
ref: ${{ github.ref }}
13 changes: 11 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
# NOTE: Since the `:latest` tag can have npm version changes, we are using
# a specific version tag. Container build errors have come up locally
# and via github action workflow when `:latest` is updated.
#
# Image info: https://catalog.redhat.com/software/containers/ubi9/nodejs-18/62e8e7ed22d1d3c2dfe2ca01
# Relevant PRs:
# - https://github.com/konveyor/tackle2-ui/pull/1746
# - https://github.com/konveyor/tackle2-ui/pull/1781

# Builder image
FROM registry.access.redhat.com/ubi9/nodejs-18:latest as builder
FROM registry.access.redhat.com/ubi9/nodejs-18:1-88 as builder

USER 1001
COPY --chown=1001 . .
RUN npm clean-install && npm run build && npm run dist
RUN npm clean-install --ignore-scripts && npm run build && npm run dist

# Runner image
FROM registry.access.redhat.com/ubi9/nodejs-18-minimal:latest
Expand Down
Loading