✨Build presets & map analysis state functions #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
+ Coverage 39.20% 41.97% +2.77%
==========================================
Files 146 175 +29
Lines 4857 5644 +787
Branches 1164 1417 +253
==========================================
+ Hits 1904 2369 +465
- Misses 2939 3154 +215
- Partials 14 121 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
requested changes
Nov 6, 2024
There was a problem hiding this comment.
The commit with refactoring needs to be moved to separate PR. One way to do it is as follows:
// do a backup - rename a branch to "..._v1" and push to GH
// NOTE that I've changed char "&" to word "and"
// "&" is an operator in bash shell and requires escaping/quoting
» git branch -M buildPresets_and_mapAnalysisState_functions_v1
» git push origin HEAD
// obtain commit hash
» git log -1 | cat 130 ↵
commit c070fa6827ff42de08cf510c792428beed7c3a81
Author: HadasahR <[email protected]>
Date: Sun Nov 3 14:05:13 2024 +0200
refactoring code as suggested in #2100
Signed-off-by: HadasahR <[email protected]>
// create a new branch "..._v2"
» git checkout -b buildPresets_and_mapAnalysisState_functions_v2 origin/main
// copy the commit to new branch
» git cherry-pick c070fa6827ff42de08cf510c792428beed7c3a81
// force push to the PR branch
» git push origin HEAD:"buildPresets_&_mapAnalysisState_functions" --force
client/src/app/pages/applications/components/application-analysis-status.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/components/application-analysis-status.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: HadasahR <[email protected]>
mguetta1
force-pushed
the
buildPresets_&_mapAnalysisState_functions
branch
from
27068ea to
f6e5257
Compare
Signed-off-by: Maayan Hadasi <[email protected]>
mguetta1
force-pushed
the
buildPresets_&_mapAnalysisState_functions
branch
from
d25f964 to
e23c630
Compare
… consistency Signed-off-by: Maayan Hadasi <[email protected]>
mguetta1
force-pushed
the
buildPresets_&_mapAnalysisState_functions
branch
from
e23c630 to
179248d
Compare
Signed-off-by: Maayan Hadasi <[email protected]>
sjd78
pushed a commit
to sjd78/tackle2-ui
that referenced
this pull request
Feb 1, 2025
refactoring code according to comments in issue konveyor#2100 these functions are used in the PR there --------- Signed-off-by: HadasahR <[email protected]> Signed-off-by: Maayan Hadasi <[email protected]> Co-authored-by: Maayan Hadasi <[email protected]> Co-authored-by: Maayan Hadasi <[email protected]>
This was referenced Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring code according to comments in issue #2100
these functions are used in the PR there