Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Replace EmptyState with StateNoData component for consistency #2164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (b654645) to head (9e59ffa).
Report is 246 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
+ Coverage   39.20%   41.98%   +2.78%     
==========================================
  Files         146      175      +29     
  Lines        4857     5630     +773     
  Branches     1164     1409     +245     
==========================================
+ Hits         1904     2364     +460     
- Misses       2939     3145     +206     
- Partials       14      121     +107     
Flag Coverage Δ
client 41.98% <ø> (+2.78%) ⬆️
server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On this screen we do not distinguish between no-data-available and no-results-found(no data due to applied filters).
The current message is inaccurate when there is no data at all. The proposed message goes in the opposite direction.
The best solution would be to separate both use cases. This however would require more knowledge about applied filters - probably based on getFilterHubRequestParams().

PatternFly guidelines for reference:

  1. no results found (due to filtering) - https://www.patternfly.org/components/empty-state/design-guidelines#no-results
  2. no data (yet) - https://www.patternfly.org/components/empty-state/design-guidelines#level-of-detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants