Only use var in Builder when needed

kordlib · Aug 15, 2023 · dc7b61b · dc7b61b
1 parent 6dd04a8
commit dc7b61b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/common/build/generated/ksp/metadata/commonMain/kotlin/dev/kord/common/entity/Permission.kt b/common/build/generated/ksp/metadata/commonMain/kotlin/dev/kord/common/entity/Permission.kt
@@ -126,7 +126,7 @@ public class Permissions internal constructor(
     public fun copy(code: DiscordBitSet = this.code): Permissions = Permissions(code)
 
     public class Builder(
-        private var code: DiscordBitSet = EmptyBitSet(),
+        private val code: DiscordBitSet = EmptyBitSet(),
     ) {
         public operator fun Permission.unaryPlus() {
             this@Builder.code.add(this.code)

diff --git a/gateway/build/generated/ksp/metadata/commonMain/kotlin/dev/kord/gateway/Intent.kt b/gateway/build/generated/ksp/metadata/commonMain/kotlin/dev/kord/gateway/Intent.kt
@@ -125,7 +125,7 @@ public class Intents internal constructor(
     public fun copy(code: DiscordBitSet = this.code): Intents = Intents(code)
 
     public class Builder(
-        private var code: DiscordBitSet = EmptyBitSet(),
+        private val code: DiscordBitSet = EmptyBitSet(),
     ) {
         public operator fun Intent.unaryPlus() {
             this@Builder.code.add(this.code)

diff --git a/ksp-processors/src/main/kotlin/generation/bitflags/Builder.kt b/ksp-processors/src/main/kotlin/generation/bitflags/Builder.kt
@@ -22,7 +22,12 @@ internal fun TypeSpec.Builder.addBuilder() {
             }
         }
         addProperty(valueName, valueCN, PRIVATE) {
-            mutable()
+            mutable(
+                when (valueType) {
+                    INT -> true
+                    BIT_SET -> false
+                }
+            )
             initializer(valueName)
         }