Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift German hyphenation patterns #549

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Uplift German hyphenation patterns #549

merged 1 commit into from
Dec 17, 2023

Conversation

zwim
Copy link
Contributor

@zwim zwim commented Dec 2, 2023

Well, I was lazy. The last update was 9 months ago. ;)
Maybe this PR will find its way into 2023.12?

Happy new year and a peaceful Christmas for all!!!


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Dec 2, 2023

cr3gui/data/hyph/German.pattern:36780: parser error : Comment not terminated 
<!--
See: http://projekte.dante.de/Trennmuster/WebHome

^
cr3gui/data/hyph/German.pattern:36780: parser error : Start tag expected, '<' not found

^

Happy new year and merry Christmas (a bit early ;-)!

@poire-z
Copy link
Contributor

poire-z commented Dec 17, 2023

Sorry, forgot about this PR. Given the initial christmas enthusiasm and broken XML, I thought it would better wait for the new year sobriety :)
Dunno if it's safe to bring it with the crengine fix bump for the coming up stable :/

@Frenzie
Copy link
Member

Frenzie commented Dec 17, 2023

The changes are very minor. Whatever would be better or worse are probably just some edge cases.

@poire-z
Copy link
Contributor

poire-z commented Dec 17, 2023

So, merging & bumping ?

@Frenzie
Copy link
Member

Frenzie commented Dec 17, 2023

Let's do it. You can blame me if someone complains Rindfleischetikettierungsüberwachungsaufgabenübertragungsgesetz is suddenly no longer correctly hyphenated. ;-D

@poire-z poire-z merged commit c89bd62 into koreader:master Dec 17, 2023
1 check passed
@zwim zwim deleted the updateGermanHyphPatterns branch December 17, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants