Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French.pattern #553

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Update French.pattern #553

merged 4 commits into from
Feb 28, 2024

Conversation

cramoisi
Copy link
Contributor

@cramoisi cramoisi commented Jan 16, 2024

Hello there !
As requested by @poire-z, one change to deal with some rare cases of l-l at the end of a line.


This change is Reviewable

dealing with churchil-l
@poire-z
Copy link
Contributor

poire-z commented Jan 16, 2024

Thanks !
Any thought about my previous "issue" with neu-ros-ciences at #157 (comment) ?

@cramoisi
Copy link
Contributor Author

cramoisi commented Jan 16, 2024 via email

@cramoisi
Copy link
Contributor Author

cramoisi commented Feb 8, 2024

Yop,
I forgot how to add a change to an update :)
I add <pattern>neu5ro5s6ciences</pattern> ; can you see it ?

add rule for neu-ro-sciences
@poire-z
Copy link
Contributor

poire-z commented Feb 8, 2024

Thanks!

<pattern>neu5ro5s6ciences</pattern>

Not familiar with all things hyph patterns and how they work, but shouldn't we try to match for neuroscien* so to also do the right thing with neuroscientifique ?

@cramoisi
Copy link
Contributor Author

cramoisi commented Feb 8, 2024 via email

@poire-z
Copy link
Contributor

poire-z commented Feb 26, 2024

Gentle ping :)
(My reading of "Les neuroscientifiques à l'époque de Churchill" is on hold since a few months ago, and I'm eager to finish it :)

@cramoisi
Copy link
Contributor Author

that should do the trick.

@poire-z poire-z merged commit 119b873 into koreader:master Feb 28, 2024
1 check passed
@poire-z
Copy link
Contributor

poire-z commented Feb 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants