-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lvdocview: fix and expose functionality for displaying author and book title separately in the status bar #575
Conversation
Looks alright (minus the minor indentation issues we see at the bottom of the Files change pane on GitHub). |
There seems to be a lot of whitespace issues in the project. I felt it was mildly out of scope for this PR. I can make some minor, localized edits to more closely match the code around them, if that's the only blocker to this being merged. |
Yes, there are mixed and ugly whitespace mismatchs. |
Anything else I can do? |
Looks ok, will merge in a few days - we're still waiting for a stable release of koreader to bump crengine, as it includes some possibly risky commits. |
No change in koreader-base I assume? |
If it isn't synced, then the author will be always displayed in the top left with the alt status bar. |
I enjoy using KOReader, and I especially like using the alt status bar, but the author and title switching every page was distracting on my Kindle PW2's e-ink display. The functionality seemed to be mostly in place already, but wasn't entirely exposed. I have made an implementation of the feature in KOReader and plan to make a pull request to that repo as well, if this pull request gets merged. I have tested the feature in the emulator and it appears to be working properly, but a second opinion would be much appreciated.
This change is