Fix a few text selection issues #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benoit-pierre : can we solve this ? Or should we just go on? |
See #608. |
Fix text selection when starting/ending selection on a blank line created by <br/><br/> (which would just not work) or at the end of a paragraph ending with <br/> (which would select the full paragraph).
It would be stuck on an infinite loop when selected text would span over a line full of spaces, which could happen with "white-space: pre".
benoit-pierre
added a commit
to benoit-pierre/koreader-base
that referenced
this pull request
Nov 24, 2024
Frenzie
pushed a commit
to koreader/koreader-base
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lvtinydom: add printf to debug global hash mismatch
Needed when investigating koreader/koreader#8613 (comment), so good to keep that at hand.
lvtinydom: createXPointer(): better handle
<br/>edge casesFix text selection when starting/ending selection on a blank line created by
<br/><br/>(which would just not work) or at the end of a paragraph ending with<br/>(which would select the full paragraph).Noticed while working on fixing koreader/koreader#12135.
lvtinydom: getSegmentRects(): fix possible infinite loop
It would be stuck on an infinite loop when selected text would span over a line full of spaces, which could happen with "
white-space: pre".Noticed at #584 (comment).
This change is