Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: text typography by language #1082

Merged
merged 1 commit into from
Apr 18, 2020

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Apr 18, 2020

Includes koreader/crengine#337 :

  • Fix a few clang-tidy warnings
  • Add support for <img src="data:image/png;base64,...>
  • XML parsing: add more HTML5 named entities, optimize search
  • Text: fix standalone BR not making an empty line
  • Fix BR with "display: block" not making an empty line
  • Fix hyphens from soft-hyphens not part of highlighted segments
  • Use libunibreak for line breaking
  • Adds TextLangMan for text typography by language

The added cre.getTextLangStatus() will allow us to get a feel of what languages have been seen and which hyph dicts loaded:

image

Noting a little thing that got me searching for a bug for quite some time:
The TextLangCfg tags we will see there are the ones that were actually seen by the code.
For a same book:

  • on initial load or re-rendering: the full book content will be visited, so all the existing lang= attributes tags will appear here
  • after exit and load from cache, this list will be smaller, and lang= attributes tags will appear here only when they are met: when you turn pages and meet new sections of the book that are to be rendered and drawn.

This change is Reviewable

Includes:
- Fix a few clang-tidy warnings
- Add support for <img src="data:image/png;base64,...>
- XML parsing: add more HTML5 named entities, optimize search
- Text: fix standalone BR not making an empty line
- Fix BR with "display: block" not making an empty line
- Fix hyphens from soft-hyphens not part of highlighted segments
- Use libunibreak for line breaking
- Adds TextLangMan for text typography by language
@poire-z
Copy link
Contributor Author

poire-z commented Apr 18, 2020

@Frenzie: are you fine if I bump this into frontend later this afternoon?
Is your tag v2020.04.1 enough for you to get binaries to add to the release?

@poire-z
Copy link
Contributor Author

poire-z commented Apr 18, 2020

And btw, didn't you need this month to do as [i18n] Bump translations submodule for v2020.03 release last month?

@Frenzie
Copy link
Member

Frenzie commented Apr 18, 2020

You're right, I forgot that. It doesn't matter for the resulting builds; it's just a matter of syncing up translations with the code if you should want to check out that tag in the future.

@poire-z poire-z merged commit fed5fa8 into koreader:master Apr 18, 2020
@poire-z poire-z deleted the bump_crengine branch April 18, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants