Skip to content

Commit

Permalink
remove Rust artifacts during make clean
Browse files Browse the repository at this point in the history
This should use `cargo clean` instead of `rm -rf ...`. Also,
due to a typo, the `rm` did not actually remove the Rust artifacts.

Signed-off-by: Thomas Bertschinger <[email protected]>
Signed-off-by: Kent Overstreet <[email protected]>
  • Loading branch information
bertschingert authored and Kent Overstreet committed Dec 20, 2023
1 parent 0bacefd commit 2b97686
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ endif

ifeq ($(BUILD_VERBOSE),1)
Q =
CARGO_CLEAN_ARGS = --verbose
else
Q = @
CARGO_CLEAN_ARGS = --quiet
endif

CFLAGS+=-std=gnu11 -O2 -g -MMD -Wall -fPIC \
Expand Down Expand Up @@ -46,9 +48,12 @@ CARGO_ARGS=${CARGO_TOOLCHAIN}
CARGO=cargo $(CARGO_ARGS)
CARGO_PROFILE=release
# CARGO_PROFILE=debug
CARGO_MANIFEST=--manifest-path rust-src/Cargo.toml

CARGO_BUILD_ARGS=--$(CARGO_PROFILE)
CARGO_BUILD=$(CARGO) build $(CARGO_BUILD_ARGS)
CARGO_BUILD=$(CARGO) build $(CARGO_BUILD_ARGS) $(CARGO_MANIFEST)

CARGO_CLEAN=$(CARGO) clean $(CARGO_CLEAN_ARGS) $(CARGO_MANIFEST)

include Makefile.compiler

Expand Down Expand Up @@ -177,7 +182,7 @@ libbcachefs.a: $(filter-out ./tests/%.o, $(OBJS))

RUST_SRCS=$(shell find rust-src/src rust-src/bch_bindgen/src -type f -iname '*.rs')
rust-src/target/release/libbcachefs_rust.a: $(RUST_SRCS)
$(CARGO_BUILD) --manifest-path rust-src/Cargo.toml
$(CARGO_BUILD)

tests/test_helper: $(filter ./tests/%.o, $(OBJS))
@echo " [LD] $@"
Expand Down Expand Up @@ -222,7 +227,7 @@ install_systemd: $(systemd_services) $(systemd_libfiles)
clean:
@echo "Cleaning all"
$(Q)$(RM) bcachefs libbcachefs.a tests/test_helper .version *.tar.xz $(OBJS) $(DEPS) $(DOCGENERATED)
$(Q)$(RM) -rf rust-src/*/target
$(Q)$(CARGO_CLEAN)
$(Q)$(RM) -f $(built_scripts)

.PHONY: deb
Expand Down

0 comments on commit 2b97686

Please sign in to comment.