Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix False positive for non-decorator use of validator #818

Merged

Conversation

koxudaxi
Copy link
Owner

Closes: #784

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (25cae75) 72.02% compared to head (f332026) 72.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   72.02%   72.13%   +0.10%     
==========================================
  Files          27       27              
  Lines        2084     2092       +8     
  Branches      643      643              
==========================================
+ Hits         1501     1509       +8     
  Misses        277      277              
  Partials      306      306              
Files Coverage Δ
.../koxudaxi/pydantic/PydanticReferenceContributor.kt 91.30% <100.00%> (+4.63%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Qodana Community for Python

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@koxudaxi koxudaxi merged commit 87c92a9 into main Oct 12, 2023
5 checks passed
@koxudaxi koxudaxi deleted the fix_false_positive_for_non-decorator_use_of_validator branch October 12, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for non-decorator use of validator
1 participant