Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] AliG optimizer visualization + Some plots showing optimizer vars #350

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

AidinHamedi
Copy link
Contributor

@AidinHamedi AidinHamedi commented Feb 14, 2025

Problem (Why?)

execute_steps in examples/visualize_optimizers.py will modify optimizer_config for some optimizers with unique requirements and that will cause the modification of the original best_params var and that will cause the next function plot_function show invalid information.

Solution (What/How?)

Make a copy of the best_params before giving it to execute_steps to mitigate the modification of the original var.

Notes

N/A

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (00fbae0) to head (2d0142c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #350   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         8890      8890           
=========================================
  Hits          8890      8890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AidinHamedi AidinHamedi changed the title fix: fixing AliG optimizer visualization [Fix] AliG optimizer visualization + Some plots showing optimizer vars Feb 14, 2025
@AidinHamedi AidinHamedi marked this pull request as draft February 14, 2025 16:54
@AidinHamedi AidinHamedi marked this pull request as ready for review February 14, 2025 18:51
@kozistr kozistr added the bug Something isn't working label Feb 15, 2025
Copy link
Owner

@kozistr kozistr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks

@kozistr kozistr merged commit 464f4e4 into kozistr:main Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants