Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TestClient): call task_done after the topic has consumed the cr #138

Merged

Conversation

marcosschroh
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28a377d) 94.10% compared to head (1fe4e6e) 95.90%.
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   94.10%   95.90%   +1.80%     
==========================================
  Files          20       20              
  Lines         712      732      +20     
==========================================
+ Hits          670      702      +32     
+ Misses         42       30      -12     
Flag Coverage Δ
unittests 95.90% <100.00%> (+1.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh merged commit 6986e2a into kpn:master Nov 27, 2023
6 of 7 checks passed
@marcosschroh marcosschroh deleted the fix/get-one-consumer-test-client branch November 27, 2023 16:31
marcosschroh added a commit to marcosschroh/kstreams that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants