Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first steps to add dependency injection. Inspect udf coroutines… #141

Conversation

marcosschroh
Copy link
Collaborator

… in order to inject different args on it

Copy link
Contributor

github-actions bot commented Dec 4, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-06 13:52 UTC

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b863948) 95.90% compared to head (7b18045) 95.94%.

Files Patch % Lines
kstreams/streams.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   95.90%   95.94%   +0.04%     
==========================================
  Files          20       21       +1     
  Lines         732      764      +32     
==========================================
+ Hits          702      733      +31     
- Misses         30       31       +1     
Flag Coverage Δ
unittests 95.94% <97.82%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosschroh marcosschroh force-pushed the feat/inspect-udf-coroutines-to-inject-different-args-on-it branch from 0c35892 to 9ab0852 Compare December 4, 2023 15:09
@marcosschroh marcosschroh marked this pull request as draft December 4, 2023 15:21
@marcosschroh marcosschroh force-pushed the feat/inspect-udf-coroutines-to-inject-different-args-on-it branch from 9ab0852 to 635a132 Compare December 5, 2023 11:46
@marcosschroh marcosschroh marked this pull request as ready for review December 5, 2023 11:47
docs/stream.md Show resolved Hide resolved
README.md Show resolved Hide resolved
kstreams/streams.py Outdated Show resolved Hide resolved
kstreams/streams.py Outdated Show resolved Hide resolved
@marcosschroh marcosschroh force-pushed the feat/inspect-udf-coroutines-to-inject-different-args-on-it branch from 635a132 to 7b18045 Compare December 6, 2023 13:34
@marcosschroh marcosschroh merged commit b2461b6 into master Dec 6, 2023
7 checks passed
@marcosschroh marcosschroh deleted the feat/inspect-udf-coroutines-to-inject-different-args-on-it branch December 6, 2023 13:52
@marcosschroh marcosschroh mentioned this pull request Jan 11, 2024
marcosschroh added a commit to marcosschroh/kstreams that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants