Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: StreamEngine hooks on_startup, on_stop, after_startup and after… #193

Conversation

marcosschroh
Copy link
Collaborator

…_stop added

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.58%. Comparing base (063b2e6) to head (a0e9cd0).

Files Patch % Lines
kstreams/utils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   95.56%   95.58%   +0.02%     
==========================================
  Files          23       23              
  Lines         856      884      +28     
==========================================
+ Hits          818      845      +27     
- Misses         38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/engine.md Outdated Show resolved Hide resolved
@woile
Copy link
Member

woile commented Jul 4, 2024

LGTM

@marcosschroh marcosschroh force-pushed the feat/add-stream-engine-start-and-stop-events branch from 2d296b9 to a0e9cd0 Compare July 4, 2024 13:16
@marcosschroh marcosschroh merged commit 9148052 into kpn:master Jul 4, 2024
7 of 8 checks passed
@marcosschroh marcosschroh deleted the feat/add-stream-engine-start-and-stop-events branch July 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants