Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR introduced a breaking change, because it removes support for python 3.8
This PR adds benchmark capabilities to the repo by using pytest-benchmark
This will allow us to guarantee no regressions on performance on the benchmarked code.
As of now, I've added a check for
benchmark-compare-fail=min:5%
:But it's worth exploring and adding more options.
How it works?
./script/bench-current
, it will create ajson
file inside.benchmarks/
per platform and python version (probably a lot of files because we test against many versions, which is good), the results will be commited and pushed back to the primary branch, it will not trigger a new release../script/bench-current
, creating ajson
file, but this time, it won't be commited. Instead it will just check that it's not over a certain threshold../scripts/bench-compare
is a convenience script which you can run locally.