Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Pip 20+ support and fix tests #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjholtkamp
Copy link

Apparently, the tests did not run since the
testenv did not match, so the builds were green
no matter the code.

I changed the tox.ini and added py38-pip20 and
made sure it failed before fixing the imports
in pkgversion.py.

On another note, we should probably not use
internals like this because it will randomly
break (like now). Fixing it now so we are
unblocked at least.

@mjholtkamp mjholtkamp force-pushed the feature/bugfix-pip20 branch from d22686d to 578d983 Compare March 31, 2020 11:02
Apparently, the tests did not run since the
testenv did not match, so the builds were green
no matter the code.

I changed the tox.ini and added py38-pip20 and
made sure it failed before fixing the imports
in pkgversion.py.

On another note, we should probably not use
internals like this because it will randomly
break (like now). Fixing it now so we are
unblocked at least.
@mjholtkamp mjholtkamp force-pushed the feature/bugfix-pip20 branch from 578d983 to d681ee4 Compare March 31, 2020 11:13
@sergray
Copy link
Contributor

sergray commented Apr 7, 2020

The same problem was acknowledged in #15

@@ -25,7 +25,8 @@
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add python 3.6?

Copy link
Contributor

@kammala kammala Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it does not seem as FIX to me as we are officially dropping support for python version and adding support for next one. more like NEW or even BREAK(even though it is only python classifiers which do not mean it won't work with other versions)

py36-{pip9,pip10}: python3.6
cov: python3.6
py27: python2.7
py37: python3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also keep py36 here as it is the main platform for this package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants