Add disableServerLogging option #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnicpt
reviewed
Oct 6, 2020
test/test.js
Outdated
| @@ -128,4 +128,47 @@ describe('beaver-logger tests', () => { | |||
| } | |||
| }); | |||
| }); | |||
|
|
|||
| it('should not send event to server if enableServerLogging is false', () => { | |||
There was a problem hiding this comment.
if disableServerLogging is true
mnicpt
reviewed
Oct 6, 2020
test/test.js
Outdated
| logEndpoint.expectCalls(); | ||
| return $logger.flush().then(() => { | ||
| try { | ||
| logEndpoint.done(); // will throw is not API calls received by logEndpoint |
There was a problem hiding this comment.
// will throw if API calls received by logEndpoint. How will it throw? I'm guessing you are referring to the if check below if the handler was called. If so, this comment is confusing since we //pass in the catch.
There was a problem hiding this comment.
https://github.com/krakenjs/sync-browser-mocks/blob/master/README.md#xmlhttprequest
it('should correctly call /api/user', function() {
myListener.expectCalls();
// Run some code which would call the api
myListener.done(); // This will throw if the api was not called
});
I can set a variable in the catch block to indicate that an exception is indeed thrown.
mnicpt
approved these changes
Oct 6, 2020
|
Can this be done an a per level basis? I would like to avoid sending debug logs to the server side unless they are enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19 by adding
disableServerLoggingoption.Usage
const logger = Logger({ url: '/test/api/log', disableServerLogging: true });