-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add isIpadOs device check #114
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/* @flow */ | ||
|
||
import { isIpadOs } from "../../../src/device"; | ||
|
||
describe("isIpadOs", () => { | ||
beforeEach(() => { | ||
window.navigator = {}; | ||
}); | ||
|
||
it("should return true when userAgent is Safari and has multiple maxTouchPoints", () => { | ||
window.navigator.userAgent = | ||
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.2 Safari/605.1.15"; | ||
// eslint-disable-next-line compat/compat | ||
window.navigator.maxTouchPoints = 5; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected true, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return true when userAgent is Firefox and has multiple maxTouchPoints", () => { | ||
window.navigator.userAgent = | ||
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.0 Safari/605.1.15"; | ||
// eslint-disable-next-line compat/compat | ||
window.navigator.maxTouchPoints = 5; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected true, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return true when userAgent is Chrome and has multiple maxTouchPoints", () => { | ||
window.navigator.userAgent = | ||
"Mozilla/5.0 (iPad; CPU OS 17_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/120.0.6099.119 Mobile/15E148 Safari/604.1"; | ||
// eslint-disable-next-line compat/compat | ||
window.navigator.maxTouchPoints = 5; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected true, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return true when userAgent is iPad", () => { | ||
window.navigator.userAgent = "iPad"; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected true, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return false when userAgent is Safari but has no touchpoints", () => { | ||
window.navigator.userAgent = | ||
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.2 Safari/605.1.15"; | ||
// eslint-disable-next-line compat/compat | ||
window.navigator.maxTouchPoints = 0; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected false, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return false when userAgent contains iPhone", () => { | ||
window.navigator.userAgent = "iPhone"; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected false, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
|
||
it("should return false when userAgent contains iPod", () => { | ||
window.navigator.userAgent = "iPod"; | ||
const bool = isIpadOs(); | ||
if (!bool) { | ||
throw new Error(`Expected false, got ${JSON.stringify(bool)}`); | ||
} | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest explicitly equating to a boolean for these