Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: move to typescript and vitest #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore!: move to typescript and vitest #11

wants to merge 1 commit into from

Conversation

westeezy
Copy link
Contributor

  • Codebase is migrated to TypeScript by using https://github.com/Khan/flow-to-ts
  • Dist folder now outputs esm folder
  • Package.json update for types & modules
  • Flowgen is used to generate flow types from dist/*.d.ts

@westeezy westeezy requested review from gregjopa and wsbrunson June 30, 2022 00:28
@westeezy westeezy force-pushed the typescript2 branch 5 times, most recently from 73d5d9b to 96b6421 Compare June 30, 2022 22:38
@westeezy westeezy force-pushed the typescript2 branch 3 times, most recently from 12e09f7 to 565b208 Compare November 22, 2022 18:56
@westeezy westeezy marked this pull request as ready for review November 22, 2022 18:56
@westeezy westeezy requested a review from dtjones404 November 22, 2022 18:57
@westeezy westeezy force-pushed the typescript2 branch 2 times, most recently from ce04f85 to e72cf0b Compare November 22, 2022 19:01
@westeezy
Copy link
Contributor Author

Published alpha: @krakenjs/[email protected]

dist
├── cross-domain-safe-weakmap.js
├── cross-domain-safe-weakmap.js.map
├── cross-domain-safe-weakmap.min.js
├── cross-domain-safe-weakmap.min.js.map
└── esm
    ├── index.d.ts
    ├── index.js
    ├── index.js.flow
    ├── native.d.ts
    ├── native.js
    ├── native.js.flow
    ├── util.d.ts
    ├── util.js
    ├── util.js.flow
    ├── weakmap.d.ts
    ├── weakmap.js
    └── weakmap.js.flow

westeezy
westeezy commented Nov 22, 2022
View reviewed changes
package.json Show resolved Hide resolved
@westeezy
chore!: move to typescript and vitest
796b711 
- Codebase is migrated to TypeScript by using https://github.com/Khan/flow-to-ts
- Dist folder now outputs esm folder
- Package.json update for types & modules
- Flowgen is used to generate flow types from dist/*.d.ts

fix: package updates + grumbler-scripts@8

fix: webpack types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtjones404 dtjones404 dtjones404 approved these changes

@gregjopa gregjopa Awaiting requested review from gregjopa

@wsbrunson wsbrunson Awaiting requested review from wsbrunson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westeezy @dtjones404