Allows mocking XHR request with an invalid status response #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Mar 14, 2022
borodovisin
force-pushed
the
options-status
branch
from
6efb33f to
8e28840
Compare
borodovisin
force-pushed
the
options-status
branch
from
8e28840 to
bebbed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR makes a proposal to allow passing invalid status code/values on XHR mocking calls, also calls all the registered events listeners to the mocked instance.
Why are we making these changes?
To be able to enable unhappy test cases after mocking an endpoint. Now any kind of invalid status will be replaced with a 200 status code. There can be cases where we need to mock an endpoint setting the status code to something invalid like
null.Caveats
This is a proposed solution where the status code will keep values such as:
[null, 0, false]and only will take the default one when isundefined. Can be a major change if some repos rely onstatus = nulland are expecting a 200 status code in the response