fix #172: handle ZEND_VERIFY_NEVER_TYPE when uopz.exit is disabled #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornrunner
force-pushed
the
master
branch
2 times, most recently
from
bf6fe81 to
0c55324
Compare
|
Closing and re-opening to (hopefully) trigger the CI workflow. |
cmb69
reviewed
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should handle #172
When
uopz.exitis disabled, actual call toexit()implicitly returns and violates never return type check.I'd appreciate it if @cmb69 or @remicollet could check it / merge it. Thanks!