Version 0.1.3 Release

- Don't register command when playground file is empty - Removed playground.php file from tests Signed-off-by: RJ Garcia <[email protected]>
krakphp · Jun 4, 2020 · b8cba15 · b8cba15
1 parent a4a7fce
commit b8cba15
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 0.1.3 - 2020-06-03
+
+- Only register the playground command if playground file exists
+
 ## 0.1.2 - 2020-06-03
 
 - Added test coverage

diff --git a/src/DependencyInjection/PlaygroundCompilerPass.php b/src/DependencyInjection/PlaygroundCompilerPass.php
@@ -15,6 +15,7 @@ public function process(ContainerBuilder $container) {
         $projectDir = $container->getParameter("kernel.project_dir");
         $reflectionFn = self::loadPlaygroundCallableReflection($projectDir . '/playground.php');
         if (!$reflectionFn) {
+            $container->removeDefinition("krak.symfony_playground.playground_command");
             return;
         }
 

diff --git a/tests/Feature/Fixtures/playground.php b/tests/Feature/Fixtures/playground.php
diff --git a/tests/Feature/PlaygroundTest.php b/tests/Feature/PlaygroundTest.php
@@ -28,6 +28,7 @@ protected function tearDown(): void {
             $this->kernel->shutdown();
             shell_exec("rm -rf {$this->kernel->getCacheDir()}");
         }
+        $this->given_the_playground_php_file_is_removed();
     }
 
     protected function createKernel() {
@@ -46,6 +47,7 @@ public function test_does_nothing_if_no_playground_file_exists() {
         $this->when_the_kernel_is_booted();
         $this->then_no_exceptions_should_be_thrown();
         $this->then_the_container_should_be_built(1);
+        $this->then_the_service_does_not_exist('krak.symfony_playground.playground_command');
     }
 
     public function test_rebuilds_sf_di_cache_on_first_invoke() {
@@ -77,6 +79,12 @@ public function test_rebuilds_sf_di_cache_if_playground_params_change() {
         $this->then_the_container_should_be_built(2);
     }
 
+    public function test_allows_playground_files_with_no_args() {
+        $this->given_the_playground_php_file_is_set_with('');
+        $this->when_the_kernel_is_booted();
+        $this->then_no_exceptions_should_be_thrown();
+    }
+
     private function given_the_kernel_is_booted_and_waits(?int $seconds = 1) {
         $this->when_the_kernel_is_booted();
         if ($seconds) {
@@ -125,4 +133,8 @@ private function then_no_exceptions_should_be_thrown() {
     private function then_the_container_should_be_built(int $times) {
         $this->assertEquals($times, $this->kernel->containerBuildCount);
     }
+
+    private function then_the_service_does_not_exist(string $id) {
+        $this->assertFalse($this->kernel->getContainer()->has($id));
+    }
 }