Always attach events

kraxarn · Nov 17, 2024 · ca414b8 · ca414b8
1 parent c79c4ac
commit ca414b8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/src/spotifyclient/runner.cpp b/src/spotifyclient/runner.cpp
@@ -13,6 +13,18 @@ SpotifyClient::Runner::Runner(const lib::settings &settings,
 	path = QString::fromStdString(settings.spotify.path);
 	process = new QProcess(parent);
 	clientType = SpotifyClient::Helper::clientType(path);
+
+	connect(process, &QProcess::readyReadStandardOutput,
+		this, &Runner::onReadyReadOutput);
+
+	connect(process, &QProcess::readyReadStandardError,
+		this, &Runner::onReadyReadError);
+
+	connect(process, &QProcess::started,
+		this, &Runner::onStarted);
+
+	connect(process, &QProcess::errorOccurred,
+		this, &Runner::onErrorOccurred);
 }
 
 SpotifyClient::Runner::~Runner()
@@ -126,18 +138,6 @@ void SpotifyClient::Runner::start()
 		arguments.append(additional_arguments.split(' '));
 	}
 
-	QProcess::connect(process, &QProcess::readyReadStandardOutput,
-		this, &Runner::onReadyReadOutput);
-
-	QProcess::connect(process, &QProcess::readyReadStandardError,
-		this, &Runner::onReadyReadError);
-
-	QProcess::connect(process, &QProcess::started,
-		this, &Runner::onStarted);
-
-	QProcess::connect(process, &QProcess::errorOccurred,
-		this, &Runner::onErrorOccurred);
-
 	lib::log::debug("starting: {} {}", path.toStdString(),
 		joinArgs(arguments).toStdString());
 

diff --git a/src/spotifyclient/runner.hpp b/src/spotifyclient/runner.hpp
@@ -40,7 +40,7 @@ namespace SpotifyClient
 		void statusChanged(const QString &status);
 
 	private:
-		QProcess *process = nullptr;
+		QProcess *process;
 		QWidget *parentWidget = nullptr;
 		QString path;
 		static std::vector<lib::log_message> log;