Fixed #1225 #1226
Merged
Fixed #1225 #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked this PR and it is working fine. |
devansh-webkul
requested changes
Jun 12, 2024
| { | ||
| $organization = $this->model->findOrFail($id); | ||
|
|
||
| $organization->persons->each->delete(); |
There was a problem hiding this comment.
This will cause DDOS. Use single query to delete all the persons.
$organization->persons()->delete();
|
|
||
| $organization->persons()->delete(); | ||
|
|
||
| $this->attributeValueRepository->deleteWhere([ |
There was a problem hiding this comment.
This will remove all other entities also. Add entity_type as well.
Comment on lines
83
to
90
| $organization->persons()->delete(); | ||
|
|
||
| $this->attributeValueRepository->deleteWhere([ | ||
| 'entity_id' => $id, | ||
| 'entity_type' => 'organizations', | ||
| ]); | ||
|
|
||
| $organization->delete($id); |
There was a problem hiding this comment.
Wrap this multiple deletion in transaction to make it atomic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed for #1225
on organization delete, persons are removed but can't be saved again.
removed attribute values of persons on organization delete.