Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting cpu shares #575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blackskyliner
Copy link

This PR implements #331

@Blackskyliner Blackskyliner force-pushed the kreuzwerker/terraform-provider-docker/issues/331 branch from c910c11 to 42259c0 Compare July 31, 2023 13:30
@jizusun
Copy link

jizusun commented Aug 9, 2023

Hi @Blackskyliner , thank you for such a great work!

I'm wondering how can I use your fork before it's merged?

@Blackskyliner
Copy link
Author

Blackskyliner commented Aug 14, 2023

@jizusun

As far as I know you will have to follow this: https://developer.hashicorp.com/terraform/language/providers/requirements#in-house-providers

So register it with either a private registry or under your own namespace in the official registry.

EDIT: Or host it as local_mirror or even network_mirror which may be a bit more involved: https://developer.hashicorp.com/terraform/cli/config/config-file#provider-installation

@midoriiro
Copy link

Any news about this PR ?

@twsl
Copy link

twsl commented Jan 6, 2024

would love to see this merged

@Blackskyliner
Copy link
Author

I don't get why this is not moving anywhere.
No initial review done in almost a year now.

There is need for this by some, it makes sense to integrate it as it was done for gpus.

So is this whole repository/plugin deprecated not maintained anymore?

I can also see that its not top-priority to look into this repository until they need it for their business but it would be great if at least on an occasional basis one of the authorized people could look into some PRs. Otherwise the PR feature could just be disabled to indicate that nothing can be contributed because of never-reviewed-because-of-time-or-incentive-constraints, as contributors also take their time to provide the patch as PR which may also lead to double implementations as seen here where now both implementations will need to be compared as which to integrate if a review gets to get going, increasing the workload for the reviewer.

@enc
Copy link
Contributor

enc commented May 7, 2024

We are moving forward to fix the pipeline in the newest PR. If this is done, we will work on all the PRs. Unfortunately it will take a short while to get up to speed in the project. Your support would be apprechiated. #613

@Blackskyliner Blackskyliner force-pushed the kreuzwerker/terraform-provider-docker/issues/331 branch from 42259c0 to fc85b7e Compare June 5, 2024 21:04
@Blackskyliner
Copy link
Author

Rebased onto current master w/o problems and/or any conflicts.

Do I need to add a test for the changes or do we assume that the config parsing and used library is well-tested enough.

@mthemis-provenir
Copy link

I don't know how feasible this is, but a really useful addition would be the ability to specify the CPU number in percent. That way if deployed to a different kind of host with more / less CPUs, it would adjust the amount of CPU allocated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants