Fixes the 'Display not ready' error and album playing #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, if I do a search and press `RET` on a track it says `[Display not ready]` on the minibufer and it does nothing (I think it has to do with not having any `action` defined in helm, just `action-transformer`). With this fix, pressing `RET` or `TAB` on the track selected will trigger the playing of the track. Also, the `Play album` wasn't behaving properly. It just played the first song of the track and then it stopped. The fix there has to do with the URI that is passed to Spotify. And I think it isn't necesary to make another http call to get the album information, its's just there in the first request, so i wipe out that function (`spotify-get-track`) entirely
|
Tried looking up the options that the helm function can take (in order to not lose the track name), but didn't find much info in the helm documentation 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if I do a search and press
RETon a track it says[Display not ready]on the minibufer and it does nothing (I think it has to do with nothaving any
actiondefined in helm, justaction-transformer).With this fix, pressing
RETorTABon the track selected will trigger theplaying of the track.
One thing that will be lost in this PR is the name of the track in the options
(e.g:
Play track - <track name>), but I think is better to have this fix that thetrack name in that menu 👍
Also, the
Play albumwasn't behaving properly. It just played the first songof the track and then it stopped. The fix there has to do with the URI that is
passed to Spotify. And I think it isn't necesary to make another http call to
get the album information, its's just there in the first request, so i wipe out
that function (
spotify-get-track) entirely