Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating prometheus-kube version to fix the issue with deprecated resources #1122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ncau
Copy link

@ncau ncau commented Mar 13, 2024

Changed the kube-prometheus clone to the latest version and changed applys to creates to avoid issues with customResourceDefintition length. Also had to change the applys to creates in order to avoid issues with custom resource definition lengths.

There might still be issues with the github runners so checking this here.

…pplys to creates to avoid issues with customResourceDefintition length
@ncau ncau marked this pull request as ready for review March 13, 2024 10:29
@ncau
Copy link
Author

ncau commented Mar 14, 2024

Seems were running 1.19 of kubernetes from what I found after 1.25 the relevant packages are fully deprecated (not 100% sure from what version on minikube they exceeded 1.25 but 1.30.1 minikube is running 1.26.3). Is this a case of we individually should run older minikube/kubernetes builds or is it something that needs to be bumped in the pipeline @dinogun?

@ncau
Copy link
Author

ncau commented Mar 15, 2024

Alternatively assuming we dont want to update autotune to be compatible post 1.25, we can do a check for the kubernetes version via kubectl. Then force the user to try with the final version of minikube prior to 1.26 (1.25.2) by spawning the minikube instance with --version 1.25.2 in the common helper(I have already written this if preferred). There is currently a check done but only in the hpo_demo_setup and it extracts the version from minikube directly instead of via kubectl which means that even if you run the correct version of kubernetes via minikube with a --version command it will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant