Add test script for authentication #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saad Khan <[email protected]>
khansaad
force-pushed
the
bearer-auth-tests
branch
from
4b448ab to
9eeb3da
Compare
Signed-off-by: Saad Khan <[email protected]>
chandrams
reviewed
Nov 25, 2024
| @@ -182,3 +182,13 @@ Else, you can change the workload name and namespace name in the test to match w | |||
|
|
|||
| Note: The test will fail if it's run as is if there are no matching workloads that the test looks for. This test result can be ignored in case of a non-gpu workload | |||
|
|
|||
| ### Authentication Test: | |||
|
|
|||
| Kruize 0.1.1 supports the authentication which provides the user an option to pass authentication details in the yaml for the service they are using. | |||
There was a problem hiding this comment.
This should be 0.2 instead of 0.1.1. Also describe the scenarios added here
| @@ -51,97 +33,149 @@ tokens=( | |||
| ["invalid"]="random-invalid-token-string" | |||
| ["empty"]="" | |||
| ) | |||
| # Tests to validate authentication types in Kruize | |||
| function authentication_tests() { | |||
There was a problem hiding this comment.
Can you share the results run
There was a problem hiding this comment.
There was a problem hiding this comment.
@khansaad - Expired token I think is same as invalid token here, we need to check how to simulate expired token. We cannot do this later.
There was a problem hiding this comment.
Also, I think it will be good to invoke some code that makes use of the token along with checking the pod log, you can add it as an enhancement to the test.
There was a problem hiding this comment.
Created #1386 to track this
Signed-off-by: Saad Khan <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new script to test the authentication feature.
Fixes # (1286)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here