KAMS - 4: Adds Recommendation updater and MIG based recommendation mechanism #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharathappali Please fix the conflicts |
bharathappali
force-pushed
the
gpu-update-impl-4
branch
from
d9bbae9 to
af40f8b
Compare
|
@bharathappali New conflicts, please fix |
bharathappali
force-pushed
the
gpu-update-impl-4
branch
from
b5eaf13 to
d8162ca
Compare
khansaad
reviewed
Feb 14, 2025
| @@ -194,7 +194,7 @@ public static void markAcceleratorDeviceStatusToContainer(ContainerData containe | |||
| if (null == resultArray || resultArray.isEmpty()) { | |||
| // Need to alert that container max duration is not detected | |||
| // Ignoring it here, as we take care of it at generate recommendations | |||
There was a problem hiding this comment.
looks like we need to update the comment here
There was a problem hiding this comment.
I feel we need that comment as these functions markAcceleratorPartitionDeviceStatusToContainer & markAcceleratorDeviceStatusToContainer try to extract the accelerator details from prometheus and while checking the code we might add alerts (In future) thinking that it's missing here.
This comment helps in understanding that it's not required to alert the user twice about the same thing. Please correct me if I'm wrong.
src/main/java/com/autotune/analyzer/recommendations/utils/RecommendationUtils.java
Outdated
Show resolved
Hide resolved
dinogun
reviewed
Feb 14, 2025
src/main/java/com/autotune/analyzer/autoscaler/accelerator/AcceleratorAutoscalerImpl.java
Outdated
Show resolved
Hide resolved
dinogun
reviewed
Feb 14, 2025
src/main/java/com/autotune/analyzer/autoscaler/accelerator/AcceleratorAutoscalerImpl.java
Outdated
Show resolved
Hide resolved
dinogun
reviewed
Feb 14, 2025
src/main/java/com/autotune/analyzer/autoscaler/accelerator/AcceleratorAutoscalerImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
bharathappali
force-pushed
the
gpu-update-impl-4
branch
from
d8162ca to
65802f1
Compare
Signed-off-by: bharathappali <[email protected]>
Signed-off-by: bharathappali <[email protected]>
dinogun
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KAMS - Kruize Accelerator MIG-tuning Service
The Recommendation Updater is added to update the workloads which has MIG partitions created by
Instaslice. We set the updater value at the time of recommendation generation and updater changes the resources once it's triggeredType of change
How has this been tested?
Tests are pending due to unavailability of accelerator hardware
Test Configuration
Checklist 🎯