Add Performance profile table in the DB #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saakhan <[email protected]>
Signed-off-by: saakhan <[email protected]>
…e-table # Conflicts: # src/main/java/com/autotune/database/service/ExperimentDBService.java
Signed-off-by: saakhan <[email protected]>
Signed-off-by: saakhan <[email protected]>
Signed-off-by: saakhan <[email protected]>
rbadagandi1
modified the milestones:
Kruize 0.0.16_rm Release,
Kruize 0.0.17_rm Release
|
@khansaad - Please update the fault tolerant test to check kruize restart works without having to create the performance profile again. |
dinogun
reviewed
Aug 11, 2023
| public class KruizePerformanceProfileEntry { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long performance_profile_id; |
There was a problem hiding this comment.
What is this id and why is this the IDENTITY?
@msvinaykumar this is the same problem that we had with the results table. Please use name as the IDENTITY instead
…file_id as it's not required Signed-off-by: saakhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to add new table
kruize_performance_profilesand it's corresponding DAO and Model classes.This will fix #790