Get data to generate recommendation #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvinaykumar
modified the milestones:
Kruize 0.0.17_rm Release,
Kruize 0.0.16_rm Release
msvinaykumar
force-pushed
the
getDataToGenRecommendation
branch
from
5528d84 to
1febe68
Compare
rbadagandi1
modified the milestones:
Kruize 0.0.16_rm Release,
Kruize 0.0.17_rm Release
msvinaykumar
force-pushed
the
getDataToGenRecommendation
branch
from
d5f5877 to
a10ccd7
Compare
dinogun
modified the milestones:
Kruize 0.0.17_rm Release,
Kruize 0.0.19_rm Release,
Kruize 0.0.18_rm Release
|
@msvinaykumar - Are these changes internal? Does these changes affect the API behavior or externals in any way? |
msvinaykumar
force-pushed
the
getDataToGenRecommendation
branch
from
a10ccd7 to
70780ea
Compare
msvinaykumar
force-pushed
the
getDataToGenRecommendation
branch
2 times, most recently
from
e72378b to
5138166
Compare
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
Signed-off-by: msvinaykumar <[email protected]>
msvinaykumar
force-pushed
the
getDataToGenRecommendation
branch
from
5138166 to
455e7c6
Compare
Signed-off-by: msvinaykumar <[email protected]>
dinogun
reviewed
Aug 14, 2023
| int limitRows = (int) (( | ||
| KruizeConstants.RecommendationEngineConstants.DurationBasedEngine.DurationAmount.LONG_TERM_DURATION_DAYS * | ||
| KruizeConstants.DateFormats.MINUTES_FOR_DAY) | ||
| / kruizeObject.getTrial_settings().getMeasurement_durationMinutes_inDouble()); |
There was a problem hiding this comment.
Should this be limitRows = LONG_TERM_MINS / durationMins + 1?
There was a problem hiding this comment.
ok I see that it is existing code moved inside the generateRecommendation method now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier results data are retrieved outside performance profile util
now logic is moved into Perf profile.