Refactor/add hal as datastructure #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
from
d91ff9d to
3388641
Compare
CohenArthur
reviewed
Jul 30, 2024
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
2 times, most recently
from
5616c9b to
bd7612f
Compare
Skallwar
force-pushed
the
refactor/add-hal-as-datastructure
branch
4 times, most recently
from
120894e to
012f9aa
Compare
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
2 times, most recently
from
79d0437 to
bf53293
Compare
Skallwar
force-pushed
the
refactor/add-hal-as-datastructure
branch
2 times, most recently
from
3382a7c to
d1320cd
Compare
Skallwar
reviewed
Oct 21, 2024
Skallwar
reviewed
Oct 21, 2024
|
|
||
| gic.init_distributor(); | ||
|
|
||
| gic | ||
| } | ||
|
|
||
| pub fn disable_interrupts(&mut self) { |
There was a problem hiding this comment.
&mut encoded the fact that this would have side-effect in a way. Let's see how it goes in practice then
There was a problem hiding this comment.
I stopped doing that because having global mutables is a nightmare.
kernel/src/generic_main.rs
Outdated
| let (gicd_base, gicc_base) = (0x800_0000, 0x801_0000); | ||
| HAL.kpt().lock().identity_map_range( | ||
| VAddr::new(gicd_base), | ||
| 0x0001_0000 / HAL.page_size(), |
There was a problem hiding this comment.
I would rather have a calculus or a const than just 0x0001_0000
There was a problem hiding this comment.
Looks like this comment was on an older version of this branch which was mistakenly pushed, I pushed the actual revision.
There was a problem hiding this comment.
(te current code does this by looking up the gic node in the device tree)
| hal::mm::enable_paging(); | ||
| log::trace!("going to enable paging..."); | ||
| HAL.enable_paging()?; | ||
| log::trace!("enabled paging !"); |
| @@ -7,7 +6,7 @@ use log::error; | |||
| fn panic(info: &core::panic::PanicInfo) -> ! { | |||
| error!("\x1b[31mkernel panic\x1b[0m: {}", info); | |||
|
|
|||
| error!("hal panic info: {:X?}", hal::panic_info()); | |||
| error!("hal panic info:"); // {:X?}", hal::panic_info()); | |||
There was a problem hiding this comment.
Why ':' if we don't print anything else
Taken from rust, very minor modifications on my side.
n1tram1
force-pushed
the
refactor/add-hal-as-datastructure
branch
from
d1320cd to
9a30ec0
Compare
Skallwar
reviewed
Oct 22, 2024
| registers::set_sscratch(core_id); | ||
| } | ||
| fn core_id() -> usize { | ||
| // Early kernel code called Self::init and putthe core_id argument into the sscratch. |
There was a problem hiding this comment.
Suggested change
| // Early kernel code called Self::init and putthe core_id argument into the sscratch. | |
| // Early kernel code called Self::init and put the core_id argument into the sscratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.