Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #17: Unified IMU #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChristopherLuey
Copy link

This pull request addresses issue #17 by implementing a unified IMU scheme for bounty.

#17

Create a unified IMUData struct in the imu crate to standardize IMU data across all implementations.
Replace implementation-specific structs (e.g., BnoData) with the new IMUData struct in each IMU-related crate.
Refactor dependencies so the imu crate becomes the central repository for the schema

@WT-MM WT-MM self-requested a review January 21, 2025 19:39
@WT-MM
Copy link
Member

WT-MM commented Jan 21, 2025

Awesome, will take a closer look later but until then could you fix the failing checks? You'll have to build (most?) of the imu crates with a linux system because of some of the dependencies

@ChristopherLuey
Copy link
Author

The issue with the build is that I had to expose data.rs. I'll see if build works and address your feedback so it is as polished as possible.

@WT-MM
Copy link
Member

WT-MM commented Jan 22, 2025

The issue with the build is that I had to expose data.rs. I'll see if build works and address your feedback so it is as polished as possible.

Cool yeah, we're also gonna want to check that pip installing works too if you haven't taken a look into the bindings directory yet

https://github.com/kscalelabs/imu/actions/runs/12915632452/job/36018773014?pr=18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants