Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pasta comments #2

Merged
merged 1 commit into from
Apr 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions sim/humanoid_gym/envs/getup_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,13 +319,8 @@ def _reward_base_height(self):
The reward is computed based on the height difference between the robot's base and the average height
of its feet when they are in contact with the ground.
"""
# TODO pfb30 - adjust that based on the body
base_height = self.root_states[:, 2] - default_feet_height
reward = torch.exp(
-torch.abs(base_height - self.cfg.rewards.base_height_target) * 100
)
# print(reward, base_height - self.cfg.rewards.base_height_target, base_height)
# print(base_height)

return base_height

def _reward_base_acc(self):
Expand Down
1 change: 0 additions & 1 deletion sim/humanoid_gym/envs/legs_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ def __init__(
env_handle, actor_handle, joint
)
self.legs_joints["right_" + name] = joint_handle
breakpoint()
self.compute_observations()

def _push_robots(self):
Expand Down
2 changes: 1 addition & 1 deletion sim/humanoid_gym/play.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def play(args: argparse.Namespace) -> None:
logger = Logger(env.dt)
robot_index = 0 # which robot is used for logging
joint_index = 1 # which joint is used for logging
stop_state_log = 200 # number of steps before plotting states
stop_state_log = 1200 # number of steps before plotting states

if RENDER:
camera_properties = gymapi.CameraProperties()
Expand Down
Loading