✨ Feature: CNI and Addons #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dipankar Das <[email protected]>
now you can use the debug mode menu driven --debug-cli Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
|
Ci failing please fix it. |
dipankardas011
changed the title
Signed-off-by: Dipankar Das <[email protected]>
dipankardas011
commented
Feb 13, 2025
Horiodino
reviewed
Feb 13, 2025
Signed-off-by: Dipankar Das <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Changelog
This pull request includes significant changes to the
ksctlCLI tool, primarily focusing on enhancing the user interface and integrating a newmenuDrivencomponent for user interactions. Additionally, it refactors the handling of addons and improves the overall code structure.Key changes include:
User Interface Enhancements:
cli.DropDownandcli.TextInputPasswordwithk.menuDrivenequivalents for various user prompts, improving consistency and user experience. (cmd/configure.go,cmd/connect.go,cmd/create.go,cmd/delete.go,cmd/get.go) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Addons Management:
addonClientSetupmethod to streamline the setup process for addon operations. (cmd/addons.go)EnableAddonandDisableAddoncommands to include user prompts and error handling for enabling and disabling addons. (cmd/addons.go) [1] [2]Code Refactoring:
ListAddonmethod and unnecessary imports to clean up the codebase. (cmd/addons.go,cmd/create.go) [1] [2]menuDrivenfield to theKsctlCommandstruct for enhanced user interaction management. (cmd/cli.go)These changes collectively improve the usability, maintainability, and functionality of the
ksctlCLI tool.🏋🏼 Issues
✅ Completed Issues
📎 Related Issues
🚀 Task List
🔍 Review Checklist
📸 Screenshots/Recordings
📌 Additional Notes
💡 PR best practices
pre-commitfor that run this command$ pre-commit install