Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): feature added #56

Merged
merged 7 commits into from
Feb 22, 2025
Merged

feat(telemetry): feature added #56

merged 7 commits into from
Feb 22, 2025

Conversation

dipankardas011
Copy link
Member

πŸ—’οΈ Changelog

  • data on what commands was executed is captured

πŸ‹πŸΌ Issues

βœ… Completed Issues

  • Fixes:

πŸ“Ž Related Issues

  • Related to:

πŸš€ Task List

  • [ ]
  • [ ]

πŸ” Review Checklist

  • Code follows project style guidelines
  • Added/updated tests
  • Ran tests locally
  • Updated documentation
  • Checked Contribution Guidelines

πŸ“Έ Screenshots/Recordings

πŸ“Œ Additional Notes


πŸ’‘ PR best practices
  • Keep changes focused and atomic
  • Update tests and documentation
  • Check for conflicts with main branch
  • Respond promptly to review comments
  • Follow project coding standards
  • Make sure you are using pre-commit for that run this command $ pre-commit install

@dipankardas011 dipankardas011 marked this pull request as draft February 18, 2025 18:03
@dipankardas011
Copy link
Member Author

need to create the subcommand to enable/disable telemetry

@dipankardas011
Copy link
Member Author

also we need to think of working in migrations
any suggestions on how to make this work @Horiodino

@dipankardas011
Copy link
Member Author

also we need to think of working in migrations any suggestions on how to make this work @Horiodino

This is needed becuase by default telelemetry needs to be enabled unless specified to turn it off

@dipankardas011
Copy link
Member Author

dipankardas011 commented Feb 21, 2025

how to share what addon is enabled or disabled
need to refine the struct

@dipankardas011
Copy link
Member Author

We can think of using ksctl cli release cert to ensure only ksctl cli can make the api calls to the endpoint πŸ€”
ksctl-cli_2.0.0_checksums.txt.cert

just that we need to see

@dipankardas011 dipankardas011 marked this pull request as ready for review February 22, 2025 17:02
Signed-off-by: Dipankar Das <[email protected]>
Copy link
Member Author

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

@dipankardas011 dipankardas011 merged commit ee92cce into main Feb 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants