-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update base minio image #11
Conversation
Signed-off-by: Rafael Vasquez <[email protected]>
Signed-off-by: Rafael Vasquez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafvasq -- I remember that newer images of minio/minio (latest-ish) did not work without refactoring MM code. The image you use in your PR here is fine in the way that the same old/depracated APIs still available.
However, the hotfix
part of the image tag of the cloudservices images has me thinking we may want to explore using a more recent image or at least find out what hotfix we would be eliminating.
Any chance you still have a local copy of the old cloudservices image on you machine so we can do an image diff?
Signed-off-by: Rafael Vasquez <[email protected]>
I agree @ckadner, but do you think we could we use this image for now to avoid blocking @israel-hdez and v0.12.0? I can investigate further and open an issue/work on a PR towards using a more recent image. |
@ckadner Some time ago, I did that exploration. The way to have a pre-seeded minio image changed quite a lot. It is still possible, but it cannot be done with a I'm also not comfortable with delivering insecure images. But... well... given the current situation, and to unblock v0.12, I wonder if we can simply document on release notes that the example images for v0.12 may be insecure and shouldn't be used in a production cluster? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we can go ahead with the old (or an equivalent) image. I think we should make the effort in the near future to upgrade the MM code to use a more recent minio image, i.e. #8 :-)
Signed-off-by: Christian Kadner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The base image
quay.io/cloudservices/minio:RELEASE.2021-06-17T00-10-46Z.hotfix.35a0912ff
stopped working.