Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeDefinition fix for dotnet build #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmintoff
Copy link

@mmintoff mmintoff commented Jul 4, 2022

Build from Visual Studio works fine. dotnet build from something like Azure build pipeline does not and gives an exception "System.Type was somehow not found. Aborting." These modification address that problem and the artifacts are built correctly. Can be tested using powershell "dotnet build".

Build from Visual Studio works fine. dotnet build from something like Azure build pipeline does not and gives an exception "System.Type was somehow not found.  Aborting." These modification address that problem and the artifacts are built correctly. Can be tested using powershell "dotnet build".
@hughesjs
Copy link

Have you got a version of this with your changes in it published anywhere? I'm having some difficulty getting it to build and install right with a local package repo

@mmintoff
Copy link
Author

Have you got a version of this with your changes in it published anywhere? I'm having some difficulty getting it to build and install right with a local package repo

Nah, hoping @kswoll takes a look at this soonish. In the meantime you could clone and pack it locally

@hughesjs
Copy link

Yeah, I did try that but after running dotnet pack on the Fody.Someta project, installing it and then referencing the Someta one (since it didn't look like it produced a nupkg when built), it still wouldn't build.

Might try again later on a fresh clone though, could just be due to a messy set of partial build files with me having used various different versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants