Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-7797 Remove application lifecycle logs from CallLogging plugin #4520

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

stokado
Copy link
Contributor

@stokado stokado commented Nov 30, 2024

Subsystem
Server (CallLogging plugin)

Motivation
UX improvement, as lifecyclke logs are already present even without this plugin

@osipxd osipxd self-requested a review December 5, 2024 22:29
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR! 🥇

@osipxd osipxd enabled auto-merge (squash) February 10, 2025 14:38
@stokado
Copy link
Contributor Author

stokado commented Feb 10, 2025

LGTM. Thank you for the PR! 🥇

If you plan to merge this, let's update license header first :)

@osipxd
Copy link
Member

osipxd commented Feb 10, 2025

let's update license header first :)

Yes, let's do it
But I've already rebased your PR, so make sure you use "pull with rebase".

auto-merge was automatically disabled February 10, 2025 14:46

Head branch was pushed to by a user without write access

@stokado
Copy link
Contributor Author

stokado commented Feb 11, 2025

@osipxd the auto-merge was disabled after my latest commit

@osipxd osipxd enabled auto-merge (squash) February 11, 2025 09:15
@osipxd osipxd merged commit 203c29c into ktorio:main Feb 11, 2025
12 of 16 checks passed
@stokado stokado deleted the fix/KTOR-7797 branch February 11, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants