Fix double actualClose call #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Feb 16, 2025
|
Hey @Thomas-Vos, thanks for the PR! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actualClose call could be called twice due to race condition when closing. Seems highly unlikely, but this could cause a descriptor to be closed twice, causing errors.
This piece of code was moved from JVM, where a double actualClose call would not have caused an issue (because closing jvm channel twice is ok), but on Native closing a descriptor twice is a serious issue.
Was able to reproduce this issue by adding
runBlocking { delay(1000) }on line 85 just beforecheckChannels()call