-
Notifications
You must be signed in to change notification settings - Fork 337
Add FilterGrep in Banzai Logging FluentbitSpec #2012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: joseacl <[email protected]>
Signed-off-by: joseacl <[email protected]>
Signed-off-by: joseacl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feature, awesome work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- charts/logging-operator/crds/logging.banzaicloud.io_fluentbitagents.yaml: Language not supported
- charts/logging-operator/crds/logging.banzaicloud.io_loggings.yaml: Language not supported
Co-authored-by: Bence Csati <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]> Signed-off-by: José Antonio Cortés López <[email protected]>
Signed-off-by: joseacl <[email protected]>
Already done, thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix #1647