Skip to content

Add FilterGrep in Banzai Logging FluentbitSpec #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 24, 2025

Conversation

joseacl
Copy link
Contributor

@joseacl joseacl commented Apr 14, 2025

Fix #1647

@csatib02 csatib02 added the enhancement New feature or request label Apr 14, 2025
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature, awesome work!

@csatib02 csatib02 self-requested a review April 14, 2025 08:22
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback!

@csatib02 csatib02 requested review from pepov and Copilot April 14, 2025 08:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 12 changed files in this pull request and generated 2 comments.

Files not reviewed (2)
  • charts/logging-operator/crds/logging.banzaicloud.io_fluentbitagents.yaml: Language not supported
  • charts/logging-operator/crds/logging.banzaicloud.io_loggings.yaml: Language not supported

joseacl and others added 7 commits April 14, 2025 11:07
Co-authored-by: Bence Csati <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
Co-authored-by: Bence Csati <[email protected]>
Signed-off-by: José Antonio Cortés López <[email protected]>
@joseacl joseacl requested a review from csatib02 April 14, 2025 09:21
@joseacl
Copy link
Contributor Author

joseacl commented Apr 14, 2025

Initial feedback!

Already done, thanks for the feedback!

Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pepov pepov merged commit 3ab40da into kube-logging:master Apr 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FilterGrep in Banzai Logging FluentbitSpec
3 participants